[PATCH] D140882: llvm-reduce: Avoid invalid attribute reduction on optnone functions

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 3 10:35:36 PST 2023


arsenm added a comment.

In D140882#4023654 <https://reviews.llvm.org/D140882#4023654>, @jdoerfert wrote:

>> ridiculous restriction
>
> +1
>
> We should not have that. It's super annoying honestly and does not help at all. Nobody would be any worse off if we remove the assertion. Shouldn't we do that?

Yes but this is an argument I remember losing when optnone was first introduced. optnone cannot be an enforceable semantic and can act like weak noinline on its own


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140882/new/

https://reviews.llvm.org/D140882



More information about the llvm-commits mailing list