[PATCH] D140882: llvm-reduce: Avoid invalid attribute reduction on optnone functions

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In D140882#4023852 <https://reviews.llvm.org/D140882#4023852>, @jdoerfert wrote:

> In D140882#4023701 <https://reviews.llvm.org/D140882#4023701>, @arsenm wrote:
>
>> In D140882#4023654 <https://reviews.llvm.org/D140882#4023654>, @jdoerfert wrote:
>>
>>>> ridiculous restriction
>>>
>>> +1
>>>
>>> We should not have that. It's super annoying honestly and does not help at all. Nobody would be any worse off if we remove the assertion. Shouldn't we do that?
>>
>> Yes but this is an argument I remember losing when optnone was first introduced. optnone cannot be an enforceable semantic and can act like weak noinline on its own
>
> I don't understand, though I vaguely remember trying to remove that assertion myself at some point.
>
> If we don't try to do the right thing anymore, this seems to be the least wrong. LG

I think this should be fixed, but I don't have the bandwidth to tilt at that particular windmill at the moment. The arguments for this was fear of QoI for some reason. It's presumptive about the implementation, since noinline actually destroys debugging on amdgpu since function debug info is incomplete (particularly upstream)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140882/new/

https://reviews.llvm.org/D140882