[PATCH] D140569: [AVR] Custom lower 32-bit shift instructions

Sun Jan 1 18:57:39 PST 2023

benshi001 added a comment.

In D140569#4021340 <https://reviews.llvm.org/D140569#4021340>, @aykevl wrote:

> - Special-case logical shifts of 16 bits. This fixes a number of issues: it avoids unnecessary code changes in this PR, it fixes an issue after rebasing on the main branch (as seen in the buildbot failure), and it fixes an issue I found while working on D140822 <https://reviews.llvm.org/D140822>.
> - Apply review feedback.
>
> This is ready for review again.

I see your idea, it is great. My only concern is that it would be better to add tests for the 16-bit shifts in current patch. You can do that while committing.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140569/new/

https://reviews.llvm.org/D140569