[PATCH] D140830: [AVR] correctly declare __do_copy_data and __do_clear_bss

Ayke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 1 17:15:56 PST 2023


aykevl added inline comments.


================
Comment at: llvm/test/CodeGen/AVR/clear-bss.ll:4
 ; CHECK: .globl __do_clear_bss
- at zeroed = internal constant [3 x i8] zeroinitializer
-
+ at zeroed = internal global [3 x i8] zeroinitializer
+ at common = common global i8 0
----------------
This was an incorrect test: constant globals are actually stored in `.rodata` which is allocated in RAM. Making it a global makes it a .bss value.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140830/new/

https://reviews.llvm.org/D140830



More information about the llvm-commits mailing list