[PATCH] D139788: [LV] Sink scalar operands and merge regions repeatedly.

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked an inline comment as done.
fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp:226
 
 bool VPlanTransforms::mergeReplicateRegions(VPlan &Plan) {
   SetVector<VPRegionBlock *> DeletedRegions;
----------------
Ayal wrote:
> Post-commit comments:
> 
> TODO: merging replicate regions can be simplified similar to merging basic-blocks below, by (renaming it mergeReplicateRegionsIntoSuccessors? and) collecting all Region1's in a Worklist and then traverse it to handle each Region1 including deleting it.
> 
> nit: would be good to record the test exercising three iterations of this while loop.
> TODO: merging replicate regions can be simplified similar to merging basic-blocks below, by (renaming it mergeReplicateRegionsIntoSuccessors? and) collecting all Region1's in a Worklist and then traverse it to handle each Region1 including deleting it.

Thanks, this should be addressed in 89718815c669.

> nit: would be good to record the test exercising three iterations of this while loop.
The test should be  `sink_replicate_region_after_replicate_region` after extension in 3d3634e8bd1f5ce543453352b6ec2ae6f29be95e


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139788/new/

https://reviews.llvm.org/D139788