[PATCH] D139788: [LV] Sink scalar operands and merge regions repeatedly.

[Ayal Zaks via Phabricator via llvm-commits]

Ayal added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp:226
 
 bool VPlanTransforms::mergeReplicateRegions(VPlan &Plan) {
   SetVector<VPRegionBlock *> DeletedRegions;
----------------
Post-commit comments:

TODO: merging replicate regions can be simplified similar to merging basic-blocks below, by (renaming it mergeReplicateRegionsIntoSuccessors? and) collecting all Region1's in a Worklist and then traverse it to handle each Region1 including deleting it.

nit: would be good to record the test exercising three iterations of this while loop.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139788/new/

https://reviews.llvm.org/D139788