[PATCH] D139184: [LLD][Windows]Feature "checksum" for Windows PE

Sun Jan 1 06:58:37 PST 2023

Qfrost911 added a comment.

In D139184#4021208 <https://reviews.llvm.org/D139184#4021208>, @tonic wrote:

> In D139184#4020932 <https://reviews.llvm.org/D139184#4020932>, @aganea wrote:
>
>> Looks good generally.
>>
>> @tonic Does your veto still hold? Can we move ahead with this patch?
>
> I have already provided feedback on the legal aspect and assuming those conditions are met (sounds like they are), then this patch is ok to go in.

Thanks. I deem that this patch includes a standard algorithm "RFC1071", and it is different between nt5src. Moreover, GCC achieves this feature, which means it is public.

Additionally, I want to know why the CI points my patch have some errors under "x64 debian failed".  I have used clangd to format "lld/COFF/Driver.cpp" before I created the patch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139184/new/

https://reviews.llvm.org/D139184