[PATCH] D140741: [llvm-profdata] Remove unnecessary file size check

[Snehasish Kumar via Phabricator via llvm-commits]

snehasish added a comment.

In D140741#4018926 <https://reviews.llvm.org/D140741#4018926>, @huangjd wrote:

> In D140741#4018895 <https://reviews.llvm.org/D140741#4018895>, @snehasish wrote:
>
>> Some filesystems have a 4GB limit on file size (notably FAT32). Given that llvm-profdata as a tool is built for multiple platforms, I don't think we should remove this check.
>
> This check is in the Reader, not Writer. The entire file is already read at this point so if there's any IO error it would happen at line 1835, which is already checked.

I see, looking at the commit which added the code doesn't seem to give any more clues apart from it being a sanity check. So then it might be ok to remove?
https://github.com/llvm/llvm-project/commit/c572e92c763f44bddfa30bc43e9027547b72dbfa

Not sure if @dnovillo


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140741/new/

https://reviews.llvm.org/D140741