[PATCH] D140741: [llvm-profdata] Remove unnecessary file size check

William Junda Huang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 28 14:39:03 PST 2022


huangjd added a comment.

In D140741#4018895 <https://reviews.llvm.org/D140741#4018895>, @snehasish wrote:

> Some filesystems have a 4GB limit on file size (notably FAT32). Given that llvm-profdata as a tool is built for multiple platforms, I don't think we should remove this check.

This check is in the Reader, not Writer. The entire file is already read at this point so if there's any IO error it would happen at line 1835, which is already checked.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140741/new/

https://reviews.llvm.org/D140741



More information about the llvm-commits mailing list