[PATCH] D140646: [AMDGPU][NFC] DWARF extensions minor update
Scott Linder via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 28 14:25:29 PST 2022
scott.linder added a comment.
LGTM save one nit
================
Comment at: llvm/docs/AMDGPUDwarfExtensionsForHeterogeneousDebugging.rst:2174
+``DW_ASPACE_none`` is defined as the target architecture default address space
+See :ref:`amdgpu-dwarf-segment_addresses``.
----------------
In most places we seem to parenthesize this kind of reference, do we want to do the same here? If not, should this be separated from the first bit by a comma or semicolon?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140646/new/
https://reviews.llvm.org/D140646
More information about the llvm-commits
mailing list