[PATCH] D133949: Make sure the right parameter extension attributes are added in various instrumentation passes.

Jonas Paulsson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 28 14:24:45 PST 2022


jonpa updated this revision to Diff 485546.
jonpa marked 2 inline comments as done.
jonpa added a comment.

Rebased.

- Incorporated the recent change of sign extending i32 returns for RISCV.

- OpenMP:

__kmpc_omp_taskwait_deps_51: also seems to have some args missing, comparing to kmp.h... The two first kmp_int32 are now SExt:ed with this patch.
kmpc_is_generic_main_thread_id: attributes / test removed after function was removed by 7ae3db6 <https://reviews.llvm.org/rG7ae3db66e8a350ce3131fa3f1a19825be3c35d61>.

> I don't think it's really related to whether we use TableGen; either way, it's still bits of C++ code, and the question is just whether we put those bits into the header, or in a switch statement in this function. But I won't push too hard for this.

If it's ok with you, it seems easier for me to wait with that change as it is not really originating in this patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133949/new/

https://reviews.llvm.org/D133949

Files:
  clang/test/OpenMP/interop_irbuilder.cpp
  llvm/include/llvm/Analysis/TargetLibraryInfo.h
  llvm/include/llvm/Frontend/OpenMP/OMPKinds.def
  llvm/lib/Analysis/TargetLibraryInfo.cpp
  llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp
  llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp
  llvm/lib/Transforms/Instrumentation/GCOVProfiling.cpp
  llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp
  llvm/lib/Transforms/Instrumentation/ThreadSanitizer.cpp
  llvm/test/Instrumentation/AddressSanitizer/experiment.ll
  llvm/test/Instrumentation/AddressSanitizer/mem-intrinsics.ll
  llvm/test/Instrumentation/MemorySanitizer/Mips/vararg-mips64.ll
  llvm/test/Instrumentation/MemorySanitizer/SystemZ/vararg.ll
  llvm/test/Instrumentation/MemorySanitizer/atomics.ll
  llvm/test/Instrumentation/MemorySanitizer/msan_basic.ll
  llvm/test/Instrumentation/ThreadSanitizer/atomic.ll
  llvm/test/Transforms/GCOVProfiling/function-numbering.ll
  llvm/test/Transforms/OpenMP/add_attributes.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D133949.485546.patch
Type: text/x-patch
Size: 136099 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221228/c9e976af/attachment-0001.bin>


More information about the llvm-commits mailing list