[PATCH] D140505: [BPF] Use SectionForGlobal() for section names computation in BTF

[Yonghong Song via Phabricator via llvm-commits]

yonghong-song added inline comments.


================
Comment at: llvm/test/CodeGen/BPF/BTF/global-var-bss-and-data.ll:2
+; RUN: llc -march=bpfel -filetype=asm -o - %s | FileCheck -check-prefixes=CHECK %s
+; RUN: llc -march=bpfeb -filetype=asm -o - %s | FileCheck -check-prefixes=CHECK %s
+
----------------
The default check-prefix is 'CHECK' so '-check-prefixes=CHECK' can be rmoved.


================
Comment at: llvm/test/CodeGen/BPF/BTF/global-var-bss-and-data.ll:15
+target datalayout = "e-m:e-p:64:64-i64:64-i128:128-n32:64-S128"
+target triple = "bpf"
+
----------------
Let us remove the above line 12-15. The 'llc' command line already has `-march=<>` flag. Also, the above target datalayout is only for little endian. The big endian datalayout is 'E-m:e-p:...'.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140505/new/

https://reviews.llvm.org/D140505