[PATCH] D140505: [BPF] Use SectionForGlobal() for section names computation in BTF

Yonghong Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 28 09:16:07 PST 2022


yonghong-song added a comment.

Otherwise, the patch LGTM.



================
Comment at: llvm/lib/Target/BPF/BTFDebug.cpp:1383
+      auto *TLOF = Asm->TM.getObjFileLowering();
+      auto *Sec = TLOF->SectionForGlobal(&Global, Asm->TM);
+      SecName = Sec->getName();
----------------
Could you change the above 'auto' to actual types? Typically we use 'auto' for some *obvious* times. The above two are not obvious.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140505/new/

https://reviews.llvm.org/D140505



More information about the llvm-commits mailing list