[PATCH] D140569: [AVR] Custom lower 32-bit shift instructions

Ben Shi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 27 18:39:37 PST 2022


benshi001 added a comment.

In D140569#4016932 <https://reviews.llvm.org/D140569#4016932>, @aykevl wrote:

> Update to use opcodes instead of `ShiftAmt` and `ArithmeticShift`.
>
> @benshi001 I updated the patch following your comment here: https://reviews.llvm.org/D138529#inline-1345614. While working on lowering the shift as a loop I found opcodes to be easier to work with. If you agree with this change, I will update all other patches as well.

Sure. Please go ahead. I do prefer the solution of exposing `opcode`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140569/new/

https://reviews.llvm.org/D140569



More information about the llvm-commits mailing list