[PATCH] D140569: [AVR] Custom lower 32-bit shift instructions

Mon Dec 26 19:32:05 PST 2022

benshi001 added a comment.

In D140569#4016932 <https://reviews.llvm.org/D140569#4016932>, @aykevl wrote:

> Update to use opcodes instead of `ShiftAmt` and `ArithmeticShift`.
>
> @benshi001 I updated the patch following your comment here: https://reviews.llvm.org/D138529#inline-1345614. While working on lowering the shift as a loop I found opcodes to be easier to work with. If you agree with this change, I will update all other patches as well.

Sure. I prefer the solution to directly export `opcode`, which looks more intuitive.

================
Comment at: llvm/lib/Target/AVR/AVRISelLowering.cpp:1841
+  MachineRegisterInfo &MRI = BB->getParent()->getRegInfo();
+  DebugLoc dl = MI.getDebugLoc();
+
----------------
aykevl wrote:
> arsenm wrote:
> > const ref
> fixed
Can it be `const DebugLoc &dl = MI.getDebugLoc();` ? In which `dl` is a reference than a local variable ?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140569/new/

https://reviews.llvm.org/D140569