[PATCH] D140680: [AArch64][MachineScheduler] Set no side effect for movprfx

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm added a comment.

Patch looks good to me but it looks like we're missing this information for all SVE instructions.  Not sure if it used to default to 0 and we missed the switch to ? but the information is missing regardless.  @Allen Is this something you plan to follow up on? or should I add it to my list?



================
Comment at: llvm/test/CodeGen/AArch64/sched-movprfx.ll:10-11
+; NOTE: The unused paramter ensures z0/z1 is free, avoiding the antidependence for schedule.
+define <vscale x 2 x i64> @and_i64_zero(<vscale x 2 x i1> %pg, <vscale x 2 x i64> %a, <vscale x 2 x i64> %b, <vscale x 2 x i64> %c, <vscale x 2 x i64>* %base) {
+; CHECK-LABEL: and_i64_zero:
+; CHECK:       // %bb.0:
----------------
Not sure you need this test given the llvm-mca explicitly emits this bit and based on my general comment do we really want tests like this for every instruction?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140680/new/

https://reviews.llvm.org/D140680