[PATCH] D140602: [RISCV] Add fmin/fmax scalar instructions to isAssociativeAndCommutative

Hsiangkai Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 25 18:34:56 PST 2022


HsiangKai added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/machine-combiner.ll:743
+  %t0 = call nsz reassoc half @llvm.minnum.f16(half %a0, half %a1)
+  %t1 = call nsz reassoc half @llvm.minnum.f16(half %t0, half %a2)
+  %t2 = call nsz reassoc half @llvm.minnum.f16(half %t1, half %a3)
----------------
asi-sc wrote:
> I believe we can remove nsz and reassoc flags here as well.
Thank you. I copied the test cases and forgot to remove them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140602/new/

https://reviews.llvm.org/D140602



More information about the llvm-commits mailing list