[PATCH] D140212: [update_test_checks] Default to --function-signature for new tests

[Alexander Richardson via Phabricator via llvm-commits]

arichardson added a comment.

In D140212#4007438 <https://reviews.llvm.org/D140212#4007438>, @asb wrote:

> Some general thoughts:
>
> Although I understand the concerns about churn from updating auto-generated tests, I was concerned that an approach like this might have greater disadvantages than just landing a patch that regenerates everything (after all, churn in auto-generated tests has far fewer practical issues vs e.g. clang-formatting - conflicts are easily resolved by regenerating).
>
> Though looking through the implementation, it doesn't seem overly complicated and seems like a sensible path forwards. I wouldn't be supportive of using such an approach for all future behaviour changes though - the complexity would just accrete and it makes the behaviour of the tool harder to predict.

I'm hoping that if we can land this, we can eventually upgrade all autogenerated tests without a function signature to use it and once that has happened, remove this workaround. I can see that there are still lots of new tests being added that don't use --function-signature and this will continue until --function-signature is the default.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140212/new/

https://reviews.llvm.org/D140212