[PATCH] D140212: [update_test_checks] Default to --function-signature for new tests

[Alex Bradbury via Phabricator via llvm-commits]

asb added a comment.

Some general thoughts:

Although I understand the concerns about churn from updating auto-generated tests, I was concerned that an approach like this might have greater disadvantages than just landing a patch that regenerates everything (after all, churn in auto-generated tests has far fewer practical issues vs e.g. clang-formatting - conflicts are easily resolved by regenerating).

Though looking through the implementation, it doesn't seem overly complicated and seems like a sensible path forwards. I wouldn't be supportive of using such an approach for all future behaviour changes though - the complexity would just accrete and it makes the behaviour of the tool harder to predict.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140212/new/

https://reviews.llvm.org/D140212