[PATCH] D140212: [update_test_checks] Default to --function-signature for new tests

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

In D140212#4007438 <https://reviews.llvm.org/D140212#4007438>, @asb wrote:

> Some general thoughts:
>
> Although I understand the concerns about churn from updating auto-generated tests, I was concerned that an approach like this might have greater disadvantages than just landing a patch that regenerates everything (after all, churn in auto-generated tests has far fewer practical issues vs e.g. clang-formatting - conflicts are easily resolved by regenerating).

For this change this would require regenerating close to 5000 tests. Not out of the question, but it's a bit more than the usual amount of churn.

Anyway, I think before making this change we should probably land D133943 <https://reviews.llvm.org/D133943> first. Doing that change will be harder if `--function-signature` is more widely used. (Alternatively, if we introduce a `--version` flag as I suggested before, we could do that as a separate version bump without test regeneration.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140212/new/

https://reviews.llvm.org/D140212