[PATCH] D139181: [lld][Alignment][NFC] Use Align instead of log2 of alignment in Wasm Sections

Guillaume Chatelet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 20 02:53:26 PST 2022


gchatelet added a comment.

In D139181#4005658 <https://reviews.llvm.org/D139181#4005658>, @MaskRay wrote:

> Thanks! I think @sbc100 will decide. From my look of these call sites, the number of `Log2` call sites makes me feel that `llvm::Align` is probably not a good fit for lld/wasm as well.

Sounds good, I'll revert then.
Note that `Log2` is a noop though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139181/new/

https://reviews.llvm.org/D139181



More information about the llvm-commits mailing list