[PATCH] D139181: [lld][Alignment][NFC] Use Align instead of log2 of alignment in Wasm Sections

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 19 11:46:37 PST 2022


sbc100 added a comment.

In D139181#4005658 <https://reviews.llvm.org/D139181#4005658>, @MaskRay wrote:

> Thanks! I think @sbc100 will decide. From my look of these call sites, the number of `Log2` call sites makes me feel that `llvm::Align` is probably not a good fit for lld/wasm as well.

I tend to agree.   I also tend to think we should either use this in all linkers on none.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139181/new/

https://reviews.llvm.org/D139181



More information about the llvm-commits mailing list