[PATCH] D138747: [Support] On Windows 11, fix an affinity mask issue on large core count machines
Alexandre Ganea via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 19 05:51:24 PST 2022
aganea added a comment.
In D138747#3974797 <https://reviews.llvm.org/D138747#3974797>, @thieta wrote:
> Is there any point in adding any tests here that can be useful? Probably not since we are working with the Windows API right? I don't have much to comment on, but it seems reasonable if it solves the problem.
The best test is the usage of the ThreadPool. However: 1. it needs a significant enough CPU load to test all sockets (as in linking clang.exe). 2. it requires a VM with WinServer 2022 and at least two or more sockets/groups. and 3. even in that case, I don't have a good way to check that all processors (as in cores) are fully utilized. The OS is now free to do what it pleases to distribute the CPU load. Unless someone has something to suggest, I don't see how to test cover this change.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138747/new/
https://reviews.llvm.org/D138747
More information about the llvm-commits
mailing list