[PATCH] D139609: [AArch64][DAGCombiner] fold instruction BIC from ISD::AND

[Dave Green via Phabricator via llvm-commits]

dmgreen added a comment.

Hello. In general we have found it is better to avoid AArch64ISD nodes if possible. That way the benefits from generic dag combines keep applying, as opposed to becoming black boxes that the rest of the optimizer cannot see. Sometimes they are necessary, and that might be the case here, but is it possible to just adjust the code using standard nodes? It doesn't seem like this applies very often though - perhaps that makes it OK in this case.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139609/new/

https://reviews.llvm.org/D139609