[llvm] 50daddf - Fix an -Wunused-variable warning in release build, NFC

[Arsenault, Matthew via llvm-commits]

[AMD Official Use Only - General]

LLT should be constexpr (I had a patch to make it constexpr, but it broke some old gcc). I should try resurrecting that patch
________________________________
From: David Blaikie <dblaikie at gmail.com>
Sent: Monday, December 12, 2022 2:30 PM
To: Haojian Wu <hokein.wu at gmail.com>; Haojian Wu <llvmlistbot at llvm.org>; Arsenault, Matthew <Matthew.Arsenault at amd.com>
Cc: llvm-commits at lists.llvm.org <llvm-commits at lists.llvm.org>
Subject: Re: [llvm] 50daddf - Fix an -Wunused-variable warning in release build, NFC

Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.


Matt - could this constant be folded into the assert so it doesn't get
left behind/simplifies the code a bit? Or is it really expensive to
build/worth keeping outside the loop like this?

On Wed, Dec 7, 2022 at 9:59 AM Haojian Wu via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
>
>
> Author: Haojian Wu
> Date: 2022-12-07T18:59:17+01:00
> New Revision: 50daddf279456c4de54133f1d626fe3fa7ebf227
>
> URL: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fllvm%2Fllvm-project%2Fcommit%2F50daddf279456c4de54133f1d626fe3fa7ebf227&data=05%7C01%7CMatthew.Arsenault%40amd.com%7C382005d3e1e3424d228d08dadc775e0c%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638064702488005359%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=iEmbjU%2FaQfYOQ6cVODwcjc0XBA%2FwIySEwE8PXLAW9ZI%3D&reserved=0
> DIFF: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fllvm%2Fllvm-project%2Fcommit%2F50daddf279456c4de54133f1d626fe3fa7ebf227.diff&data=05%7C01%7CMatthew.Arsenault%40amd.com%7C382005d3e1e3424d228d08dadc775e0c%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638064702488005359%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=PUucgBzbcVcnmc0mqGI3PT5ISXkKzgt2QEnqIhanJxs%3D&reserved=0
>
> LOG: Fix an -Wunused-variable warning in release build, NFC
>
> Added:
>
>
> Modified:
>     llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
>
> Removed:
>
>
>
> ################################################################################
> diff  --git a/llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp b/llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
> index e92509c494fa..52b601d95f07 100644
> --- a/llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
> +++ b/llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
> @@ -4835,7 +4835,7 @@ static void packImage16bitOpsToDwords(MachineIRBuilder &B, MachineInstr &MI,
>  static void convertImageAddrToPacked(MachineIRBuilder &B, MachineInstr &MI,
>                                       int DimIdx, int NumVAddrs) {
>    const LLT S32 = LLT::scalar(32);
> -
> +  (void)S32;
>    SmallVector<Register, 8> AddrRegs;
>    for (int I = 0; I != NumVAddrs; ++I) {
>      MachineOperand &SrcOp = MI.getOperand(DimIdx + I);
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.llvm.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fllvm-commits&data=05%7C01%7CMatthew.Arsenault%40amd.com%7C382005d3e1e3424d228d08dadc775e0c%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638064702488005359%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=g%2BS7FLUbn52lbNwsgYjoSf2tyzwBpct5b%2BZqZibUMtU%3D&reserved=0
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221212/a2f0735f/attachment.html>