<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Arial;font-size:10pt;color:#0000FF;margin:5pt;" align="Left">
[AMD Official Use Only - General]<br>
</p>
<br>
<div>
<div class="elementToProof"><span style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);" class="elementToProof">LLT should be constexpr (I had a patch to make it constexpr, but
it broke some old gcc). I should try resurrecting that patch<br>
</span></div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> David Blaikie <dblaikie@gmail.com><br>
<b>Sent:</b> Monday, December 12, 2022 2:30 PM<br>
<b>To:</b> Haojian Wu <hokein.wu@gmail.com>; Haojian Wu <llvmlistbot@llvm.org>; Arsenault, Matthew <Matthew.Arsenault@amd.com><br>
<b>Cc:</b> llvm-commits@lists.llvm.org <llvm-commits@lists.llvm.org><br>
<b>Subject:</b> Re: [llvm] 50daddf - Fix an -Wunused-variable warning in release build, NFC</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.<br>
<br>
<br>
Matt - could this constant be folded into the assert so it doesn't get<br>
left behind/simplifies the code a bit? Or is it really expensive to<br>
build/worth keeping outside the loop like this?<br>
<br>
On Wed, Dec 7, 2022 at 9:59 AM Haojian Wu via llvm-commits<br>
<llvm-commits@lists.llvm.org> wrote:<br>
><br>
><br>
> Author: Haojian Wu<br>
> Date: 2022-12-07T18:59:17+01:00<br>
> New Revision: 50daddf279456c4de54133f1d626fe3fa7ebf227<br>
><br>
> URL: <a href="https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fllvm%2Fllvm-project%2Fcommit%2F50daddf279456c4de54133f1d626fe3fa7ebf227&data=05%7C01%7CMatthew.Arsenault%40amd.com%7C382005d3e1e3424d228d08dadc775e0c%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638064702488005359%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=iEmbjU%2FaQfYOQ6cVODwcjc0XBA%2FwIySEwE8PXLAW9ZI%3D&reserved=0">
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fllvm%2Fllvm-project%2Fcommit%2F50daddf279456c4de54133f1d626fe3fa7ebf227&data=05%7C01%7CMatthew.Arsenault%40amd.com%7C382005d3e1e3424d228d08dadc775e0c%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638064702488005359%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=iEmbjU%2FaQfYOQ6cVODwcjc0XBA%2FwIySEwE8PXLAW9ZI%3D&reserved=0</a><br>
> DIFF: <a href="https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fllvm%2Fllvm-project%2Fcommit%2F50daddf279456c4de54133f1d626fe3fa7ebf227.diff&data=05%7C01%7CMatthew.Arsenault%40amd.com%7C382005d3e1e3424d228d08dadc775e0c%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638064702488005359%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=PUucgBzbcVcnmc0mqGI3PT5ISXkKzgt2QEnqIhanJxs%3D&reserved=0">
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fllvm%2Fllvm-project%2Fcommit%2F50daddf279456c4de54133f1d626fe3fa7ebf227.diff&data=05%7C01%7CMatthew.Arsenault%40amd.com%7C382005d3e1e3424d228d08dadc775e0c%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638064702488005359%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=PUucgBzbcVcnmc0mqGI3PT5ISXkKzgt2QEnqIhanJxs%3D&reserved=0</a><br>
><br>
> LOG: Fix an -Wunused-variable warning in release build, NFC<br>
><br>
> Added:<br>
><br>
><br>
> Modified:<br>
> llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp<br>
><br>
> Removed:<br>
><br>
><br>
><br>
> ################################################################################<br>
> diff --git a/llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp b/llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp<br>
> index e92509c494fa..52b601d95f07 100644<br>
> --- a/llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp<br>
> +++ b/llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp<br>
> @@ -4835,7 +4835,7 @@ static void packImage16bitOpsToDwords(MachineIRBuilder &B, MachineInstr &MI,<br>
> static void convertImageAddrToPacked(MachineIRBuilder &B, MachineInstr &MI,<br>
> int DimIdx, int NumVAddrs) {<br>
> const LLT S32 = LLT::scalar(32);<br>
> -<br>
> + (void)S32;<br>
> SmallVector<Register, 8> AddrRegs;<br>
> for (int I = 0; I != NumVAddrs; ++I) {<br>
> MachineOperand &SrcOp = MI.getOperand(DimIdx + I);<br>
><br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> llvm-commits@lists.llvm.org<br>
> <a href="https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.llvm.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fllvm-commits&data=05%7C01%7CMatthew.Arsenault%40amd.com%7C382005d3e1e3424d228d08dadc775e0c%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638064702488005359%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=g%2BS7FLUbn52lbNwsgYjoSf2tyzwBpct5b%2BZqZibUMtU%3D&reserved=0">
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.llvm.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fllvm-commits&data=05%7C01%7CMatthew.Arsenault%40amd.com%7C382005d3e1e3424d228d08dadc775e0c%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638064702488005359%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=g%2BS7FLUbn52lbNwsgYjoSf2tyzwBpct5b%2BZqZibUMtU%3D&reserved=0</a><br>
</div>
</span></font></div>
</div>
</body>
</html>