[llvm] 50daddf - Fix an -Wunused-variable warning in release build, NFC

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 12 11:30:31 PST 2022


Matt - could this constant be folded into the assert so it doesn't get
left behind/simplifies the code a bit? Or is it really expensive to
build/worth keeping outside the loop like this?

On Wed, Dec 7, 2022 at 9:59 AM Haojian Wu via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
>
>
> Author: Haojian Wu
> Date: 2022-12-07T18:59:17+01:00
> New Revision: 50daddf279456c4de54133f1d626fe3fa7ebf227
>
> URL: https://github.com/llvm/llvm-project/commit/50daddf279456c4de54133f1d626fe3fa7ebf227
> DIFF: https://github.com/llvm/llvm-project/commit/50daddf279456c4de54133f1d626fe3fa7ebf227.diff
>
> LOG: Fix an -Wunused-variable warning in release build, NFC
>
> Added:
>
>
> Modified:
>     llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
>
> Removed:
>
>
>
> ################################################################################
> diff  --git a/llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp b/llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
> index e92509c494fa..52b601d95f07 100644
> --- a/llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
> +++ b/llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
> @@ -4835,7 +4835,7 @@ static void packImage16bitOpsToDwords(MachineIRBuilder &B, MachineInstr &MI,
>  static void convertImageAddrToPacked(MachineIRBuilder &B, MachineInstr &MI,
>                                       int DimIdx, int NumVAddrs) {
>    const LLT S32 = LLT::scalar(32);
> -
> +  (void)S32;
>    SmallVector<Register, 8> AddrRegs;
>    for (int I = 0; I != NumVAddrs; ++I) {
>      MachineOperand &SrcOp = MI.getOperand(DimIdx + I);
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


More information about the llvm-commits mailing list