[PATCH] D138529: [AVR] Optimize constant 32-bit shifts
Ben Shi via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 7 02:54:19 PST 2022
benshi001 added inline comments.
================
Comment at: llvm/lib/Target/AVR/AVRISelLowering.cpp:1934
+ // Shift one more to the left for modulo 6 shifts.
+ if (ShiftAmt % 8 == 6) {
+ insertMultibyteShift(MI, BB, ShiftRegs, -1, false);
----------------
This `if` statement is not tested for ashr. It would be better to add an ashr6 or ashr30 test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138529/new/
https://reviews.llvm.org/D138529
More information about the llvm-commits
mailing list