[PATCH] D138525: llvm-reduce: Reduce ifuncs

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/ModuleUtils.cpp:292
+
+bool llvm::lowerGlobalIFuncUsers(GlobalIFunc &GI) {
+  bool UnhandledUsers = false;
----------------
aeubanks wrote:
> this deserves a unittest, then I'd say we don't need as many llvm-reduce-specific tests
I was going to introduce a separate lowering util pass later, I guess I can do that first


================
Comment at: llvm/test/tools/llvm-reduce/remove-ifunc-constantexpr.ll:1
+; XFAIL: *
+; The verifier should xeject this
----------------
aeubanks wrote:
> not sure how useful an XFAIL test is if the verifier should fail on this anyway and I presume nobody's producing this sort of IR
> 
> should add a FIXME verifier test separately
This is a leftover, D138634 is to disallow this


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138525/new/

https://reviews.llvm.org/D138525