[PATCH] D138525: llvm-reduce: Reduce ifuncs

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 1 17:56:43 PST 2022


arsenm added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/ModuleUtils.cpp:292
+
+bool llvm::lowerGlobalIFuncUsers(GlobalIFunc &GI) {
+  bool UnhandledUsers = false;
----------------
arsenm wrote:
> aeubanks wrote:
> > this deserves a unittest, then I'd say we don't need as many llvm-reduce-specific tests
> I was going to introduce a separate lowering util pass later, I guess I can do that first
D139163 jumps ahead to a utility pass, and switching strategy to using a global constructor


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138525/new/

https://reviews.llvm.org/D138525



More information about the llvm-commits mailing list