[PATCH] D138525: llvm-reduce: Reduce ifuncs

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added a comment.

precommit bot is saying the added tests are failing



================
Comment at: llvm/lib/Transforms/Utils/ModuleUtils.cpp:292
+
+bool llvm::lowerGlobalIFuncUsers(GlobalIFunc &GI) {
+  bool UnhandledUsers = false;
----------------
this deserves a unittest, then I'd say we don't need as many llvm-reduce-specific tests


================
Comment at: llvm/test/tools/llvm-reduce/remove-ifunc-constantexpr.ll:1
+; XFAIL: *
+; The verifier should xeject this
----------------
not sure how useful an XFAIL test is if the verifier should fail on this anyway and I presume nobody's producing this sort of IR

should add a FIXME verifier test separately


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138525/new/

https://reviews.llvm.org/D138525