[PATCH] D139006: [UpdateTestChecks] Match define for labels

[Sebastian Neubauer via Phabricator via llvm-commits]

sebastian-ne added inline comments.


================
Comment at: llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/define_after_call.ll.expected:14
+define i32 @b(i32 %arg) {
+; CHECK-LABEL: define {{[^@]+}}@b(
+; CHECK-NEXT:    ret i32 [[ARG:%.*]]
----------------
arichardson wrote:
> Does this actually fail without the define match? I wouldn't expect it to?
Yes, it fails (which is why I put the opt | FileCheck line into the .test script as well).
`CHECK-LABEL: @b(` matches the `call i32 @b(i32 0)` line and and as labels are matched before check-lines, then the `CHECK-NEXT: [[VAL:%.*]] = call i32 @b(i32 0)` line doesn’t find its match anymore (or the ret i32 match, I’m not quite sure, but it definitely fails).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139006/new/

https://reviews.llvm.org/D139006