[PATCH] D139006: [UpdateTestChecks] Match define for labels

Alexander Richardson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 30 09:27:20 PST 2022


arichardson added a comment.

Agreed that the churn is annoying, but at least unlike the function-signature flag (which I'd quite like to have on by default tbh) it only affects a single line rather than also including variable captures.



================
Comment at: llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/define_after_call.ll.expected:14
+define i32 @b(i32 %arg) {
+; CHECK-LABEL: define {{[^@]+}}@b(
+; CHECK-NEXT:    ret i32 [[ARG:%.*]]
----------------
Does this actually fail without the define match? I wouldn't expect it to?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139006/new/

https://reviews.llvm.org/D139006



More information about the llvm-commits mailing list