[llvm] e9b0bcb - [Remarks] Use std::optional in RemarkParser.cpp (NFC)
Kazu Hirata via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 25 21:13:23 PST 2022
Author: Kazu Hirata
Date: 2022-11-25T21:13:15-08:00
New Revision: e9b0bcb6a5a6fabbc18cbfae64a002eb22a18501
URL: https://github.com/llvm/llvm-project/commit/e9b0bcb6a5a6fabbc18cbfae64a002eb22a18501
DIFF: https://github.com/llvm/llvm-project/commit/e9b0bcb6a5a6fabbc18cbfae64a002eb22a18501.diff
LOG: [Remarks] Use std::optional in RemarkParser.cpp (NFC)
This is part of an effort to migrate from llvm::Optional to
std::optional:
https://discourse.llvm.org/t/deprecating-llvm-optional-x-hasvalue-getvalue-getvalueor/63716
Added:
Modified:
llvm/lib/Remarks/RemarkParser.cpp
Removed:
################################################################################
diff --git a/llvm/lib/Remarks/RemarkParser.cpp b/llvm/lib/Remarks/RemarkParser.cpp
index fc0612fb76e27..2577693d30986 100644
--- a/llvm/lib/Remarks/RemarkParser.cpp
+++ b/llvm/lib/Remarks/RemarkParser.cpp
@@ -16,6 +16,7 @@
#include "YAMLRemarkParser.h"
#include "llvm-c/Remarks.h"
#include "llvm/Support/CBindingWrapping.h"
+#include <optional>
using namespace llvm;
using namespace llvm::remarks;
@@ -109,10 +110,10 @@ namespace {
// Wrapper that holds the state needed to interact with the C API.
struct CParser {
std::unique_ptr<RemarkParser> TheParser;
- Optional<std::string> Err;
+ std::optional<std::string> Err;
CParser(Format ParserFormat, StringRef Buf,
- Optional<ParsedStringTable> StrTab = None)
+ std::optional<ParsedStringTable> StrTab = None)
: TheParser(cantFail(
StrTab ? createRemarkParser(ParserFormat, Buf, std::move(*StrTab))
: createRemarkParser(ParserFormat, Buf))) {}
More information about the llvm-commits
mailing list