[llvm] f17dbb9 - [Remarks] Use std::optional in YAMLRemarkParser.cpp (NFC)

Kazu Hirata via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 25 21:15:39 PST 2022


Author: Kazu Hirata
Date: 2022-11-25T21:15:34-08:00
New Revision: f17dbb9706a2a7ed89ed7877706264060fb28f14

URL: https://github.com/llvm/llvm-project/commit/f17dbb9706a2a7ed89ed7877706264060fb28f14
DIFF: https://github.com/llvm/llvm-project/commit/f17dbb9706a2a7ed89ed7877706264060fb28f14.diff

LOG: [Remarks] Use std::optional in YAMLRemarkParser.cpp (NFC)

This is part of an effort to migrate from llvm::Optional to
std::optional:

https://discourse.llvm.org/t/deprecating-llvm-optional-x-hasvalue-getvalue-getvalueor/63716

Added: 
    

Modified: 
    llvm/lib/Remarks/YAMLRemarkParser.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Remarks/YAMLRemarkParser.cpp b/llvm/lib/Remarks/YAMLRemarkParser.cpp
index a32629c9f557..6f879d3450c7 100644
--- a/llvm/lib/Remarks/YAMLRemarkParser.cpp
+++ b/llvm/lib/Remarks/YAMLRemarkParser.cpp
@@ -15,6 +15,7 @@
 #include "llvm/ADT/StringSwitch.h"
 #include "llvm/Support/Endian.h"
 #include "llvm/Support/Path.h"
+#include <optional>
 
 using namespace llvm;
 using namespace llvm::remarks;
@@ -322,9 +323,9 @@ YAMLRemarkParser::parseDebugLoc(yaml::KeyValueNode &Node) {
   if (!DebugLoc)
     return error("expected a value of mapping type.", Node);
 
-  Optional<StringRef> File;
-  Optional<unsigned> Line;
-  Optional<unsigned> Column;
+  std::optional<StringRef> File;
+  std::optional<unsigned> Line;
+  std::optional<unsigned> Column;
 
   for (yaml::KeyValueNode &DLNode : *DebugLoc) {
     Expected<StringRef> MaybeKey = parseKey(DLNode);
@@ -364,8 +365,8 @@ Expected<Argument> YAMLRemarkParser::parseArg(yaml::Node &Node) {
   if (!ArgMap)
     return error("expected a value of mapping type.", Node);
 
-  Optional<StringRef> KeyStr;
-  Optional<StringRef> ValueStr;
+  std::optional<StringRef> KeyStr;
+  std::optional<StringRef> ValueStr;
   Optional<RemarkLocation> Loc;
 
   for (yaml::KeyValueNode &ArgEntry : *ArgMap) {


        


More information about the llvm-commits mailing list