[PATCH] D138095: [asan] Keep Itanium mangled names in global metadata

Zequan Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 22 15:09:01 PST 2022


zequanwu added a comment.

Hi, this causes two tests failure on mac.

  Failed Tests (2):
     SanitizerCommon-tsan-x86_64-Darwin :: Darwin/symbolizer-function-offset-dladdr.cpp
     ThreadSanitizer-x86_64 :: Darwin/symbolizer-dladdr.cpp

https://reviews.llvm.org/rGdb7c82231c32074440d5426870051228435c6bce doesn't seem to fix the test because our cron job picks 57fd7ffe <https://reviews.llvm.org/rG57fd7ffefffae313de800fecdd9f095a17bfd4ea> and failed on 3 tests:

  Failed Tests (3):
     AddressSanitizer-x86_64-darwin :: TestCases/Darwin/interface_symbols_darwin.cpp
     SanitizerCommon-tsan-x86_64-Darwin :: Darwin/symbolizer-function-offset-dladdr.cpp
     ThreadSanitizer-x86_64 :: Darwin/symbolizer-dladdr.cpp

See https://bugs.chromium.org/p/chromium/issues/detail?id=1392533 for details. Please revert those two commits if it takes a while to fix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138095/new/

https://reviews.llvm.org/D138095



More information about the llvm-commits mailing list