[PATCH] D138095: [asan] Keep Itanium mangled names in global metadata

Mon Nov 21 12:24:35 PST 2022

MaskRay added a comment.

In D138095#3941961 <https://reviews.llvm.org/D138095#3941961>, @hctim wrote:

> In D138095#3941942 <https://reviews.llvm.org/D138095#3941942>, @MaskRay wrote:
>
>> I wonder whether a demangled name in odr-violation diagnostics is useful... Personally whether it is mangled/demangled doesn't concern me.
>
> Given the amount of "what does this use-after-free report mean, stop bothering me" we get, I'm appreciate a demangled name because it likely reduces the amount of bug reports assigned to me ;).

Thanks for the quick reply! Then I'll probably revert this patch and not consider reinstating it.

`compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cpp` uses an undefined weak `__cxa_demangle` which does not pull in an archive definition.
So a `-static-libstdc++` mostly-statically executable won't get demangled names.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138095/new/

https://reviews.llvm.org/D138095