[PATCH] D138095: [asan] Keep Itanium mangled names in global metadata

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 22 15:19:16 PST 2022


MaskRay added a comment.

In D138095#3945190 <https://reviews.llvm.org/D138095#3945190>, @zequanwu wrote:

> Hi, this causes two tests failure on mac.
>
>   Failed Tests (2):
>      SanitizerCommon-tsan-x86_64-Darwin :: Darwin/symbolizer-function-offset-dladdr.cpp
>      ThreadSanitizer-x86_64 :: Darwin/symbolizer-dladdr.cpp
>
> https://reviews.llvm.org/rGdb7c82231c32074440d5426870051228435c6bce doesn't seem to fix the test because our cron job picks 57fd7ffe <https://reviews.llvm.org/rG57fd7ffefffae313de800fecdd9f095a17bfd4ea> which includes it and failed on 3 tests:
>
>   Failed Tests (3):
>      AddressSanitizer-x86_64-darwin :: TestCases/Darwin/interface_symbols_darwin.cpp
>      SanitizerCommon-tsan-x86_64-Darwin :: Darwin/symbolizer-function-offset-dladdr.cpp
>      ThreadSanitizer-x86_64 :: Darwin/symbolizer-dladdr.cpp
>
> See https://bugs.chromium.org/p/chromium/issues/detail?id=1392533 for details. Please revert those two commits if it takes a while to fix.

I don't have a macOS to check issues but don't think the combination of 00be3578e0841dd9abe408e5b4946180de0bf46b <https://reviews.llvm.org/rG00be3578e0841dd9abe408e5b4946180de0bf46b>+db7c82231c32074440d5426870051228435c6bce <https://reviews.llvm.org/rGdb7c82231c32074440d5426870051228435c6bce> (which just changed a `__cxa_demangle` call site and the ODR indicator symbol name) can suppress a tsan failure).

compiler-rt/test/asan/TestCases/Darwin/interface_symbols_darwin.cpp looks like a test which is nearly impossible to investigate without a macOS though I don't think it has connection with this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138095/new/

https://reviews.llvm.org/D138095



More information about the llvm-commits mailing list