[PATCH] D138260: [RISCV] Prevent constant hoisting for (and (shl X, C), mask<<C)

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 21 08:36:59 PST 2022


reames accepted this revision.
reames added a comment.

LGTM as well w/the same comment on adding comments.  I'd also encourage a comment on the helper routine which describes the pattern you're matching and why that makes the immediate free.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138260/new/

https://reviews.llvm.org/D138260



More information about the llvm-commits mailing list