[PATCH] D138260: [RISCV] Prevent constant hoisting for (and (shl X, C), mask<<C)

[Luís Marques via Phabricator via llvm-commits]

luismarques accepted this revision.
luismarques added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/test/Transforms/ConstantHoisting/RISCV/immediates.ll:85
+
+define i32 @test10(i32 %a, i32 %b) nounwind {
+; CHECK-LABEL: @test10(
----------------
Nit: having a comment here with the rationale from the summary ("If the immediate is a shifted mask, we will use a pair of shifts and never materialize the immediate") would be convenient, since without the assembly code that might not be obvious.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138260/new/

https://reviews.llvm.org/D138260