[PATCH] D138107: [AArch64][MachineCombiner] Update isAssociativeAndCommutative

Wed Nov 16 03:31:56 PST 2022

dmgreen added a comment.

> Thanks. I didn't notice your D134260 <https://reviews.llvm.org/D134260>.
> Do you mean splitting one patch to some patches? Or, splitting `case ... return` statement in the code?

I mean a few different patches. It can be good to commit things in smaller chunks in case some part of it needs to be reverted. The patch looks sensible from what I can tell, I just feel it is doing a little too much all at once.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138107/new/

https://reviews.llvm.org/D138107