[PATCH] D138107: [AArch64][MachineCombiner] Update isAssociativeAndCommutative

KAWASHIMA Takahiro via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 16 03:45:21 PST 2022


kawashima-fj added a comment.

In D138107#3930322 <https://reviews.llvm.org/D138107#3930322>, @dmgreen wrote:

> I mean a few different patches. It can be good to commit things in smaller chunks in case some part of it needs to be reverted. The patch looks sensible from what I can tell, I just feel it is doing a little too much all at once.

Ok. Do you have a plan to add FP/NEON/SVE patches after D134260 <https://reviews.llvm.org/D134260>? If not, I'll post splitted patches after D134260 <https://reviews.llvm.org/D134260> is landed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138107/new/

https://reviews.llvm.org/D138107



More information about the llvm-commits mailing list