[PATCH] D138107: [AArch64][MachineCombiner] Update isAssociativeAndCommutative

Wed Nov 16 03:22:16 PST 2022

kawashima-fj added a comment.

In D138107#3930239 <https://reviews.llvm.org/D138107#3930239>, @dmgreen wrote:

> I think it would be best to split this up into some instruction groups. The scalar were already being handled by https://reviews.llvm.org/D134260 (ANDS can also be added). I hadn't committed that because it ran into the same pcsections test failure. I have a patch to fix it up though, I can put that up for review and get D134260 <https://reviews.llvm.org/D134260> committed.
>
> The others could be split into scalar fp/neon/sve/etc.

Thanks. I didn't notice your D134260 <https://reviews.llvm.org/D134260>.
Do you mean splitting one patch to some patches? Or, splitting `case ... return` statement in the code?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138107/new/

https://reviews.llvm.org/D138107