[PATCH] D137861: [MLIR] Move JitRunner Options to header, pass to mlirTransformer

[Renato Golin via Phabricator via llvm-commits]

rengolin added inline comments.


================
Comment at: mlir/include/mlir/ExecutionEngine/JitRunner.h:95
+};
+
 struct JitRunnerConfig {
----------------
mehdi_amini wrote:
> Seems to me that this is exposing "everything" here as a quick way to achieve what you need, but I'm a bit concerned that a lot of this has been "designed" as internal details of the JitRunner and not meant as an API: this may be slightly too much of a big hammer right now IMO. Can we do something more targeted to the "mlirTransformer" callback here? 
> 
I thought about that, as there are some other configurations flying around, so I could just create some externally visible struct. Right now, I only need `mainFuncName` and `mainFuncType`, so I could do that.

Given that the options are read-only anyway, it shouldn't matter much. If other people want more, they can increment later on.

I'll update and rebase.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137861/new/

https://reviews.llvm.org/D137861