[PATCH] D137861: [MLIR] Move JitRunner Options to header, pass to mlirTransformer

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: mlir/include/mlir/ExecutionEngine/JitRunner.h:95
+};
+
 struct JitRunnerConfig {
----------------
Seems to me that this is exposing "everything" here as a quick way to achieve what you need, but I'm a bit concerned that a lot of this has been "designed" as internal details of the JitRunner and not meant as an API: this may be slightly too much of a big hammer right now IMO. Can we do something more targeted to the "mlirTransformer" callback here? 



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137861/new/

https://reviews.llvm.org/D137861