[PATCH] D137628: [LoongArch] Implement MCTargetExpr::fixELFSymbolsInTLSFixups hook

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/test/MC/LoongArch/Misc/tls-symbols.s:1
+# RUN: llvm-mc --triple=loongarch64 --filetype=obj < %s \
+# RUN:     | llvm-readelf -s - | FileCheck %s
----------------
remove `< `

it's conventional to use `-o %t` and `llvm-readobj -s %t`


================
Comment at: llvm/test/MC/LoongArch/Misc/tls-symbols.s:7
+lu12i.w $a1, %gd_hi20(gd_abs)
+# CHECK-DAG: TLS{{.*}}UND gd_abs
+
----------------
`{{.*}}` can be expanded to `GLOBAL DEFAULT`. Only a few more characters but check some properties which could be useful.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137628/new/

https://reviews.llvm.org/D137628