[PATCH] D137628: [LoongArch] Implement MCTargetExpr::fixELFSymbolsInTLSFixups hook

[wanglei via Phabricator via llvm-commits]

wangleiat added a comment.

In D137628#3920159 <https://reviews.llvm.org/D137628#3920159>, @MaskRay wrote:

> This should use an assembly test at MC layer (llvm/test/MC)

Thanks a lot, it's done.



================
Comment at: llvm/test/CodeGen/LoongArch/tls-symbols.ll:1
+; RUN: llc --mtriple=loongarch64 --relocation-model=pic --filetype=obj < %s \
+; RUN:     -o - | llvm-readelf -s - | FileCheck %s
----------------
MaskRay wrote:
> remove `< `
thanks


================
Comment at: llvm/test/CodeGen/LoongArch/tls-symbols.ll:12
+entry:
+; CHECK: TLS{{.*}}UND unspecified
+  ret ptr @unspecified
----------------
MaskRay wrote:
> It's better to use 
> 
> `CHECK-DAG` to leave flexibility for MC to order symbol tables in another way. The symbol order is not guaranteed.
> It's better to use 
> 
> `CHECK-DAG` to leave flexibility for MC to order symbol tables in another way. The symbol order is not guaranteed.

thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137628/new/

https://reviews.llvm.org/D137628