[PATCH] D137832: [AMDGPU][AsmParser] Forbid TFE modifiers for MBUF stores.

Joe Nash via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 11 06:37:35 PST 2022


Joe_Nash added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:3282
+    for (const auto &Op : Operands) {
+      if (static_cast<const AMDGPUOperand &>(*Op).isTFE())
+        return Match_InvalidOperand;
----------------
I would prefer dynamic_cast, for safe downcasting.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137832/new/

https://reviews.llvm.org/D137832



More information about the llvm-commits mailing list