[PATCH] D137832: [AMDGPU][AsmParser] Forbid TFE modifiers for MBUF stores.

Dmitry Preobrazhensky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 11 06:27:42 PST 2022


dp added a comment.

Could you add a test to check the reported error position? Unfortunately, AsmMatcher often fails to report the location of offending operand. Moving the check to validator may improve diagnostic by using `getImmLoc`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137832/new/

https://reviews.llvm.org/D137832



More information about the llvm-commits mailing list