[PATCH] D137028: [llvm][utils] Add DenseMap data formatters (WIP)

[Dave Lee via Phabricator via llvm-commits]

kastiglione added inline comments.


================
Comment at: llvm/utils/lldbDataFormatters.py:330
+        if entry.type.name.startswith("llvm::detail::DenseMapPair<"):
+            entry = entry.GetChildAtIndex(0)
+
----------------
aprantl wrote:
> else error?
I'll add a comment about this being a nice-to-have unwrapping.

Instances of `DenseMap` can specify a custom alternative to `DenseMapPair`. In that case, this formatter will return children as-is, since it doesn't know anything about the custom type.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137028/new/

https://reviews.llvm.org/D137028